Merge all dims in pointwise scheduler #1872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am I correct that it is not necessary to skip any dimension when merging?
For trivial reduction, it is totally unrelated, because we always uses an output as reference, and we always do
cacheBefore
for that output. AftercacheBefore
, we should have a new fusion output that no longer contains any reductions.For broadcasting, I don't see any reason why it can not be merged. Our indexing system will just ignore it if it is merged I think?