forked from pytorch/pytorch
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MatMul] Update generated code after memory index hoisting #1974
Open
shmsong
wants to merge
20
commits into
predicate_shift
Choose a base branch
from
index_codegen
base: predicate_shift
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmsong
changed the title
WIP: [Not ready for Review] Update generated code after memory index hoisting
Update generated code after memory index hoisting
Sep 20, 2022
@shmsong Just skimmed through the changes. As far as I cans see, there's nothing fundamentally new analysis in this PR, but all of the changes are more like localized tweaking of generated codes as you explained in the above comment. In the interest of the time, I'll prioritize the other PRs to review. |
csarofeen
changed the title
Update generated code after memory index hoisting
[MatMul] Update generated code after memory index hoisting
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes in this PR are minor tweaking on the generated cuda code to get the intended assembly code after compilation.
Here is a list of minor codegen tweaking grouped into this PR: (more details see comments and internal doc)
1.Double Buffer Swtich to ensure UR usage in double buffered indexing
Before transform:
After transform:
Before transform:
After transform:
3.Casting lifted component to byte pointer: lifts some instructions and regs out of main loop
Before transform:
After transform:
4.Increment gmem pointer: lifts some more instructions and regs out of main loop
Before transform:
After transform:
5.Decrement gmem pointer: improves the instruction schedule
Before transform:
After transform:
Before transform:
After transform: