[MatMul] Pipe through global memory cache ops as additional scheduler options #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmsong
force-pushed
the
misc_minor_codgen_change
branch
from
47362b6
to
e9c0519
Compare
shmsong
force-pushed
the
cache_op_interface
branch
from
97c6ee9
to
d0c3fc9
Compare
shmsong
changed the title
* add matmul benchmark * more benchmark and test extension * fixes Co-authored-by: Xiang Gao <qasdfgtyuiop@gmail.com>
csarofeen
changed the title
Merged
|
This PR is cherry-picked into devel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts integration of cache operators at assembly level into
LoadStoreOps, most useful ones in matmul kernels are probablyca,cg, andcs, so starting with cg and ca on cp.async for now.TODO:
Would need some massive cleanup to enable this on a wider scale:
LoadStoreOpto supportld.globalandst.global, regardless of vectorization.UnaryOp::SETas an alias for backward compatibility.