Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More strict validation #2000

Merged
merged 1 commit into from
Sep 27, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions torch/csrc/jit/codegen/cuda/test/test_gpu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24772,10 +24772,19 @@ TEST_F(NVFuserTest, FusionBoundedDirectionSelection1_CUDA) {
scheduler_utils::BoundedDirectionalTransformPropagator::backward(
tv3, -1, {tv0, tv2});

// Check that the splits are replayed on tv1, even though tv2
// is part of the boundary.
// Check that the splits are replayed on tv2
TORCH_INTERNAL_ASSERT(
tv2->nDims() == 4, "Propagator didn't propagate to tv2");
tv2->nDims() == tv3->nDims(),
"Propagator didn't propagate to tv2: ",
tv2->toString());

// Check that the splits are replayed on tv1 as well. Even though
// one of its consumers, tv2, is part of the boundary, another
// consumer is not a boundary, so tv1 should be transformed as well.
TORCH_INTERNAL_ASSERT(
tv1->nDims() == tv3->nDims(),
"Propagator didn't propagate to tv1: ",
tv1->toString());
}

TEST_F(NVFuserTest, FusionIssueRepro1844_CUDA) {
Expand Down