Skip to content

use reference, some compilers may complain or treat it as error #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2022
Merged

use reference, some compilers may complain or treat it as error #2211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torch/csrc/jit/codegen/cuda/disjoint_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ DisjointSets<T, Hash>::DisjointSets(const DisjointSets<T, Hash>& other) {

// Deep copy the vector of the disjoint sets, keeping the same
// ordering of the sets.
for (const auto other_set : other.disjoint_sets_) {
for (const auto& other_set : other.disjoint_sets_) {
auto new_set = std::make_shared<VectorOfUniqueEntries<T, Hash>>(*other_set);
int new_set_index = disjoint_sets_.size();
disjoint_sets_.emplace_back(new_set);
Expand All @@ -356,7 +356,7 @@ DisjointSets<T, Hash>::DisjointSets(const DisjointSets<T, Hash>& other) {
}

// Copy the mappings using the new sets
for (const auto kv : other.disjoint_set_maps_) {
for (const auto& kv : other.disjoint_set_maps_) {
const auto key = kv.first;
const auto new_set_index = ptr_map.at(kv.second);
disjoint_set_maps_.emplace(key, disjoint_sets_.at(new_set_index));
Expand Down