Skip to content

[WIP] Indexing Refactor #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 36 commits into
base: devel
Choose a base branch
from
Draft

[WIP] Indexing Refactor #2316

wants to merge 36 commits into from

Conversation

@csarofeen
Copy link
Owner

@csarofeen csarofeen commented Jan 10, 2023

Work is getting pretty deep, very high level changes this is going after:

A lot of work going into separating IterDomainGraph from ComputeAtMap cleanly
converting usage of BestEffortReplay to IterDomainGraph::mapBetween
Drafting analysis for broadcast resolution in indexing

@csarofeen csarofeen force-pushed the indexing_refactoring branch from e8b1f48 to 3b2b48f Compare January 10, 2023 18:53
@csarofeen
Start reducing down IdGraph.
7e43d1d
@csarofeen
Join the different sets into one structure based on MappingMode.
7bbf730
@csarofeen
Small alias.
5581f6e
@csarofeen
More minor refactoring.
1443fcc
@csarofeen
Code movement. Split up IdGraph build process.
08b35c3
@csarofeen
Rename node -> disjoint sets.
a6d824e
@csarofeen
Make IterDomainGraph more self contained with a recursive ID mapping …
fb13a0c 
…approach.
@csarofeen
Expand comment for BestEffortReplay.
ada2af5
@csarofeen
Minor interface changes in compute at map, code movement.
4e9d268
@csarofeen
Expose forwarding info for permissive mapping.
ee50ddd
@csarofeen
Make exact and permissive maps self building.
efda269
@csarofeen
Remove BestEffortReplay use from Loop Map construction. Remove consum…
fe08382 
…er/producer map from IterDomainGraph.
@csarofeen
Small name refactor, add definition and uses API to IterDomainGraph.
37e81b3
@csarofeen
Remove ComputeAtMap's definition and uses in favor of IterDomainGraphs.
bf202a8
@csarofeen
Remove multi output function in IdGraph building, remove explicit rfa…
d787043 
…ctor mapping since it's already implicitly done.
@csarofeen
IdGraph/ComputeAt Interface Tuning and cleanup.
0321dba
@csarofeen
Minor IdGraph tweaks, continue removing some BestEffortReplay usage.
c29b427
@csarofeen
Merge getMatchedLeafPosWithoutReplay[CasP, PasC] into ...TasR.
6f28803
@csarofeen
Remove fullSelfMatching
23c05ad
@csarofeen
Treat braodcast as the exception not the rule for unskippable inlined…
a390667 
… dimensions.
@csarofeen
Minor build fixes.
3b93604
@csarofeen
Minor cleanup.
9511d76
@csarofeen
Draft loop promotion in compute at map, validate with warning initial…
14c9844 
… approach.
@csarofeen
Minor loop promotion map fix.
af28d38
@csarofeen
minor build fix.
b67e245
@csarofeen
Minor refactoring.
4e55bd1
@csarofeen
Some more minor refactoring.
e38e8f7
@csarofeen
Update iter domain graph with broadcast promotion logic. WARNING Brea…
0e6a85a 
…ks everything.
@csarofeen
Reduce verbosity, add name only option to lower dump.
33d0e04
@csarofeen csarofeen force-pushed the indexing_refactoring branch from 3b2b48f to c9e8710 Compare January 28, 2023 17:05
This was referenced Feb 25, 2023
Closed
Closed
Closed
Closed
@naoyam naoyam mentioned this pull request Mar 7, 2023
Merged
3 tasks
@jacobhinkle jacobhinkle mentioned this pull request Mar 7, 2023
Open
@csarofeen csarofeen mentioned this pull request Mar 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csarofeen