Initialization and predicate generation #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal or smem, also don't unroll if there are no inline predicates inside the loop.
naoyam
reviewed
Aug 12, 2020
| bool use_rfactor = pred_inds.second; | ||
| bool use_maybe_rfactor = pred_inds.second; | ||
|
|
||
| if (out_tv->getMemoryType() != MemoryType::Global && out_tv->hasReduction() && |
There was a problem hiding this comment.
I think we should not skip predicates for shared memory buffers as well. No predicate would mean shared memory buffers would be zero-initialized by all threads redundantly, right? That would cause race conditions, then.
There was a problem hiding this comment.
I didn't think about it, yeah that seems fair. Could you please commit that change and then go ahead and merge this if you approve otherwise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify predicate generation so we don't predicate intialization in local or smem, also don't unroll if there are no inline predicates inside the loop.
Should fix any issues introduced in #260 related to #64