Enable Global Intermediate Buffers #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rdspring1
commented
Aug 26, 2020
•
rdspring1
commented
- When the user designates a intermediate TensorView with the Global memory type, the fuser will pass the intermediate value as an argument to the kernel via global memory.
- Enable support for the default schedule.
rdspring1
force-pushed
the
rds_global_intermediate
branch
from
453fd0a
to
9ab2f8e
Compare
rdspring1
changed the title
|
I made changes so that local memory is the default type and the memory type matches between the TensorView and its corresponding allocate node. |
|
Could you also add/check there are couple things: |
rdspring1
force-pushed
the
rds_global_intermediate
branch
from
408ace1
to
9a9a8d3
Compare
csarofeen
approved these changes
Sep 1, 2020
rdspring1
force-pushed
the
rds_global_intermediate
branch
from
9a9a8d3
to
243cb52
Compare
jjsjann123
pushed a commit
that referenced
this pull request
Jun 8, 2022
…ytorch#78276) Fixes #325 **Summary**: Currently, the pytorchbot only allows for rebasing to the master branch. These modifications add functionality for rebasing to the 'viable/strict' branch of pytorch/pytorch by adding a flag to the comment. **Test Plan:** tested manually on personal fork ([#1](swang392#1)), and included a test case in test_tryrebase.py that checks if rebasing to viable/strict branch was successful. Pull Request resolved: pytorch#78276 Approved by: https://github.com/clee2000, https://github.com/janeyx99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.