Executor and segment runtime cleanup #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmsong
changed the title
csarofeen
approved these changes
Apr 9, 2021
shmsong
added a commit
that referenced
this pull request
Apr 13, 2021
shmsong
added a commit
that referenced
this pull request
May 3, 2021
* add caching in benchmarks * fix executor info * support multi-instance * minor fix * cleanup wait to merge with #800 * format * propagate profile * bug fix * comment & naming * Revert "bug fix" This reverts commit a478d76. * seg runtime bug fix * benchmark utils bug fix * fix syntax * Revert "seg runtime bug fix" This reverts commit 9d31b53. * format * clang format * remove trailing spaces * trailing space * comment * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines single-kernel executor and multi-kernel executor and makes sure in both cases the kernel compiles and launches happen in the same code-path, leading to less code and more comments.