Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from JOSS review #8

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Updates from JOSS review #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbc22da
Fix argument name in docstring
mdpiper Jul 9, 2020
32cf6d2
Add comment on origin of spec file
mdpiper Jul 9, 2020
8d3b509
Fix miniconda download URL
mdpiper Jul 9, 2020
6d77de9
Also change URL for Linux download
mdpiper Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ before_install:
fi
- |
if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
curl https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh > $HOME/miniconda.sh
curl https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh > $HOME/miniconda.sh
else
curl https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh > $HOME/miniconda.sh
curl https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh > $HOME/miniconda.sh
fi
- bash $HOME/miniconda.sh -b -p $HOME/anaconda
- export PATH="$HOME/anaconda/bin:$PATH"
Expand Down
9 changes: 8 additions & 1 deletion bmipy/bmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
"""The Basic Model Interface (BMI) Python specification.

This language specification is derived from the Scientific Interface
Definition Language (SIDL) file bmi.sidl located at
https://github.com/csdms/bmi.
"""

from abc import ABC, abstractmethod
from typing import Tuple

Expand All @@ -12,7 +19,7 @@ def initialize(self, config_file: str) -> None:
Perform all tasks that take place before entering the model's time
loop, including opening files and initializing the model state. Model
inputs are read from a text-based configuration file, specified by
`filename`.
`config_file`.

Parameters
----------
Expand Down