Add rsHSPF requirement when rsType = ASHPPM.#593
Merged
chipbarnaby merged 1 commit intomainfrom Jan 16, 2026
Merged
Conversation
Contributor
|
I think the better fix here would be to remove the requirement in the code. @chipbarnaby? |
chipbarnaby
approved these changes
Jan 16, 2026
Contributor
|
I just merged Nathan's change. But I agree removing the requirement would
be better. I have added an issue for that so I won't forget to make the
change.
…On Fri, Jan 16, 2026 at 12:44 PM Neal Kruis ***@***.***> wrote:
*nealkruis* left a comment (cse-sim/cse#593)
<#593 (comment)>
I think the better fix here would be to remove the requirement in the
code. @chipbarnaby <https://github.com/chipbarnaby>?
—
Reply to this email directly, view it on GitHub
<#593 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWGW7HJREC6TWNK7Y6C7E34HEPQ7AVCNFSM6AAAAACR6B75PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONRRGEZDOMJXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I tried creating an
RSYSobject withrsType = ASHPPM. I got the following error.S0497: 'rsHSPF' missing: required when rsType=ASHPPMI noticed the docs did not mention
rsHSPFis required whenrsType = ASHPPM, so I fixed it.Author Progress Checklist:
Reviewer Checklist: