Feat/i18n banana #118
Open
Feat/i18n banana #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the README.md so onboarding should be easier for us folks new to the project.
Added a section on using python for running a local webserver so you can actually run the E2E tests on your own computer. Added how to run ESLint. This is the last of the included scripts that was not explicitly documented.
npm reported security vulnerabilities so I just ran `npm audit fix` to deal with it.
Forgot to run prettier before commit...
Update the hardcoded URLs to go point to the correct places after the repo forking. We may want to investigate if it's possible to make these links relative instead of absolute somehow.
Add our team introduction video.
Added link to the wiki. Also changed `check` to `checking` for consistency.
Added section to cache npm dependencies. Also use the later versions of checkout and specify usage of node v20. See: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows Also replaced npm install with npm ci as suggested in the setup-node documentation. See: https://docs.npmjs.com/cli/v8/commands/npm-ci
The previous set up would only run the Jest tests post deployment to github pages on the live website and deployments only occur on the `main` branch. This will run a python webserver on the Github runner and run the tests on that. Most important, all branches will now have testing run.
Run Tests on all branches; Update Github Action Dependencies
…lity Previously `npm run docs` would result in an error, meaning it was impossible to locally generate the JSDocs on your own computer. This is now fixed. In addition, I've setup main.yml to use the same script for consistancy. The JSDocs will look slightly different than before. Previously the `Minami` theme was used, however usage of that requies taffy which allows attackers to access any data items in the Taffy database. I don't think that's important to us, since what's in there for the JSDocs should be public already but... See https://nvd.nist.gov/vuln/detail/CVE-2019-10790#range-9035153
Pipeline js docs
Bug/opencookiebutton
Bug/opencookiebutton
open cookie button
Modifiy love compatibility script so that it also will present a localized "and" to the user. Added missing entries for each sign together with itself.
Modify expected values since our function is now different after commit `b86a06e8bdbfda0a145d8bfca4fbcf18069bdfd4`.
hhcoxatucsd
force-pushed
the
feat/i18n-banana
branch
from
ce9a244 to
2b3f97f
Compare
The back button in the how-to-use popup was borked in firefox. I saw that commit `05dd123edbc70e45e6cb09dcdfcf77a7906bcca8` deletes the width attribute from #close-button (the button in question) in love-compatibility/styles.css, but then the width attriubte is just inherited from common/styles.css. This fixes that by using unset.
Keyboard navigation
Change text of Love Compatibility title from `Love Compatibility` to `Love Compat` to make things fit. Kinda awful hack but it works!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.