Update management of input files #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istry for clarity (ii) Registries' main job is to provide global access to Object keys (model forecasts, input catalog and arguments file), build the key structure (for instance, the path tree) and check if these objects already exists (iii) current (ModelFileRegistry) and future (ModelHDF5Registry, ModelSQLRegistry) concrete classes are abstracted from ModelRegistry, which has the defined interface.
…used in file-base registries. Created ExperimentRegistry abstract and File-based concrete classes. Renamed registries' interface to add/get_*_key. abstracted registry logging to be a function in the logger module. tests: added unit tests for experiment file registry
pabloitu
deleted the
53-correct-management-of-models-input-catalog-and-arg-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refac: changed forecast registry abstraction. i) renamed to model reg…istry for clarity (ii) Registries' main job is to provide global access to Object keys (model forecasts, input catalog and arguments file), build the key structure (for instance, the path tree) and check if these objects already exists (iii) current (ModelFileRegistry) and future (ModelHDF5Registry, ModelSQLRegistry) concrete classes are abstracted from ModelRegistry, which has the defined interface.