Skip to content

Conversation

@bayonato89
Copy link
Contributor

@bayonato89 bayonato89 commented Aug 1, 2024

Imported a few libraries and corrected minor errors to run the mapping_GEAR1 function

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@pabloitu pabloitu mentioned this pull request Aug 16, 2024
16 tasks
@pabloitu
Copy link
Collaborator

The tests of this PR are being blocked because of https://github.com/SCECcode/pycsep/blob/5f84ea97101de0439deb1e3f5c383874c7bb3801/csep/utils/plots.py#L7. It needs to be updated to:

from scipy.integrate import cumulative_trapezoid

@pabloitu pabloitu self-requested a review October 22, 2024 17:17
@fabiolsilva fabiolsilva merged commit 2feb914 into cseptesting:main Oct 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants