Skip to content

chore(build): update node.js version #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Use this Dockerfile for production builds
# Use node image to install Vue dependencies
FROM node:14.2 as vue-dependencies
FROM node:16 as vue-dependencies

# Set the working directory for the project in container
WORKDIR /app
Expand Down
3 changes: 1 addition & 2 deletions frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Base image node to install Vue dependencies
FROM node:14.2 AS build-stage
FROM node:16-alpine AS build-stage

WORKDIR /app

Expand All @@ -12,4 +12,3 @@ COPY . .
RUN yarn build
RUN npm install -g serve
ENTRYPOINT serve -s dist

4 changes: 2 additions & 2 deletions frontend/Dockerfile-dev
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Base image node to install Vue dependencies
FROM node:14.2 AS build-stage
FROM node:16-alpine AS build-stage

WORKDIR /app

Expand All @@ -9,4 +9,4 @@ RUN yarn install

# Build dependencies into dist folder, copy line may change as we restructure
COPY . .
ENTRYPOINT yarn serve
ENTRYPOINT yarn serve