Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix Directory Name with trailing space #385

Merged
merged 2 commits into from
Sep 27, 2023
Merged

[BUG] Fix Directory Name with trailing space #385

merged 2 commits into from
Sep 27, 2023

Conversation

josh-ramos-22
Copy link
Contributor

Why the changes are needed

One of the directories in the repo has a trailing space, which can cause issues when trying to pull the repo

Changes made

  • Removed trailing space from the CreateCodeBlock_button directory

@josh-ramos-22 josh-ramos-22 marked this pull request as ready for review September 18, 2023 04:27
@brianzhang2101 brianzhang2101 mentioned this pull request Sep 24, 2023
Open
lauraw0
lauraw0 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@lauraw0 lauraw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaaaa lgtm~

@josh-ramos-22 josh-ramos-22 merged commit 85cc526 into main Sep 27, 2023
@josh-ramos-22 josh-ramos-22 deleted the BUG_dir_with_trailing_space branch September 27, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauraw0 lauraw0 lauraw0 approved these changes

@ShunyaoLiang ShunyaoLiang Awaiting requested review from ShunyaoLiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh-ramos-22 @lauraw0