Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtrex Filters #15

Merged
merged 23 commits into from
Jan 17, 2019
Merged

Filtrex Filters #15

merged 23 commits into from
Jan 17, 2019

Conversation

Step7750
Copy link
Member

This PR has been a long time in the making, I think it's in a suitable state to be merged.

  • Since filtrex isn't published on NPM or equivalent, we unfortunately had to check it in :(
  • Minor edits to filtrex to allow a whitelist of valid vars

Features:

  • Adds customizable highlight filters on user-defined expressions
  • Saves filter settings to user's chrome sync storage (allows them to sync filters across multiple browsers)
  • Contrast aware text over user-defined colours

Step7750 added 23 commits January 31, 2017 12:00
@Step7750
Adds filtrex as a dependency
19c8ff9
@Step7750
Implements Preliminary Expression Parsing
96b65c3 
Moves over most styling to float.css
@Step7750
Enforces strict variable names and adds error div
d15dd09 
Has to overwrite compileExpression in filtrex, might just replace the
function instead over in filtrex.js.
@Step7750
Moves compileExpression overwrite to original file
01ecec0
@Step7750
Implements filter adding/removing/saving
dd9e8d1
@Step7750
Fixes Remove Index and Button Styling
bbf3bea
@Step7750
Highlights listings that match at least one filter
a1452a9 
Maybe we could add custom colours?
@Step7750
Fixes button styling
e44e956
@Step7750
Fallback to local storage if sync is not available
eb9216c
@Step7750
Adds Custom Filter Highlight Colours
965349f
@Step7750
Redraws Item Highlight Filters on Change
4b8ce82
@Step7750
Adds Filtering Help Section
89447cb
@Step7750
Adds srcElement fallback to target
64bfd71
@Step7750
Redraws Highlights on Colour Change
b626ce8
@Step7750
Adds match filter function + function help
7283727
@Step7750
Refactors Filters into Classes
c1145e0
@Step7750
Gets the Average Colour of Multiple Filter Matches
a911f2c 
If multiple filters match, returns the average colour of all filters.
@Step7750
Merges Remote Branch master (v1.1.3)
5c73e21 
Fixes Firefox issues with float fetching
@Step7750
Merge branch 'master' into feature/filtrex
34f971d
@Step7750
Ignores Compile Errors on Empty String
a7e6aae
@Step7750
Adds Contrast Aware Text Colour for Filters
fa5fefd
@Step7750
Removes "Help" Consolas font
d97273e
@Step7750
Ensures MAX_WRITE_OPERATIONS_PER_MINUTE Isn't Hit
07b5d16
@Step7750 Step7750 requested a review from bmwalters January 13, 2019 21:46
@Step7750 Step7750 merged commit 6bcbc2e into master Jan 17, 2019
@Step7750 Step7750 deleted the feature/filtrex branch January 17, 2019 21:40
This was referenced Jan 17, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmwalters bmwalters Awaiting requested review from bmwalters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Step7750 @bmwalters