Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Steam Market Sticker Container #279

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Dec 5, 2024

Motivation

In today's update, Steam introduced a new inline display for stickers and charms. Since the extension has its own sticker/charm container, we have to solve the conflict and fix all alignments.

Description

Since the extension's own container has more features, we want to adopt Steam's unique item popover while purging their new container in favor of ours:

  • Remove the new "Inspect In Game"-button in favor of our own inspect-link on-hover on the item image
  • Remove Steam's new sticker/charm container
  • Fix alignment of floatbar and overflow of tooltip according to new structure
  • Fix a bug where keychains did not get displayed because of an incorrect exit check
  • Add item popover on-hover to the extension's sticker/charm container
    image

@GODrums GODrums added the bug label Dec 5, 2024
@GODrums GODrums requested a review from Step7750 December 5, 2024 06:50
@GODrums GODrums self-assigned this Dec 5, 2024
Copy link
Member

@Step7750 Step7750 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GODrums !

@GODrums GODrums merged commit eff3c1f into master Dec 5, 2024
2 checks passed
@GODrums GODrums deleted the fix/market-entry-stickers-update branch December 5, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants