Fix: Floatbar Overflow on Market Pages #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #281.
Description
With the addition of the tooltip, we require our containers to use
overflow: visiblein order to display the the tooltip correctly.This leads to the
ItemRowWrapperoverflowing into the sticker-container, which is not a part of the same shadow-root.This PR fixes the issue by giving the main child of the Shadow-Root a
display: inline-block, making sure the whole container stays within its boundaries.Side-effect: the float-bar is now unable to dynamically adjust its size according to the parent system, meaning the maximum width will always be given by the width of the text (
Float: ...) below.Screenshots
Example with float limits 0-1:
Example with float limits 0.1-0.7: