-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support keychain and Bumps globaloffensive from 3.1.0 to 3.2.0. #226
base: master
Are you sure you want to change the base?
Conversation
Bumps steam-user from 4.29.1 to 5.2.0.
Hi @gaelsuv .First of all, thank you for your feedback. I believe you’re referring to the cache handling of charms data. I added Additionally, I noticed that Please let me know if I understood your suggestion correctly. Since my English isn't perfect, I want to make sure I didn't miss any important details. Thanks again for your feedback. I appreciate your patience and look forward to your response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
I've added a few comments, but this is in pretty good shape.
In relation to saving the charms, that should be a separate PR with being disabled by default.
Hello @wangxingzhen, I've deleted my comment because I was facing a completely different problem coming from my client interaction with the API response. I might have spotted a different bug though: are we sure the current upsert logic on items table is correct? I noticed the merge tuple is (defindex, paintindex, paintwear, paintseed), which for charms right now should be always (1355, 0, 0, 0). Am I missing something? thanks EDIT: expanding the items unique index and the ON CONFLICT clause under table INSERT to also include |
I am trying to inspect charm on steam (steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20M5252977499532233326A39982530324D12117712579169360507), and I am getting response without charm pattern. Also trying to inspect skin with Charm (steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20S76561199175645974A39945477466D4676502401872163723) that's response: |
…ield.Remove the logic: && item.defindex !== 1355.
It seems that your code does not utilize the code from this PR. |
This is cool, but maybe naming the field "paintseed" instead of "pattern". It confuses my code :) |
Guys, will you finish this PR? Thanks for this repo! |
Hi, thank you for your interest! I’ve already submitted the PR, and it’s currently waiting for the author’s review. I’m looking forward to any feedback or suggestions from them. Thanks again for supporting this repo! |
@Step7750 Hi, can you please review changes and approbe this PR, also waiting this. Thanks! |
Summary of Changes:
globaloffensive
from 3.1.0 to 3.2.0.steam-user
from 4.29.1 to 5.2.0.Detailed Changes:
globaloffensive
v3.2.0 now supports keychains:The
keychains
field has been added to the items table to store keychain data. Each keychain has a unique identifier, similar topaintseed
andpaintindex
.steam-user
upgrade to 5.2.0:This upgrade resolves a known issue where the app would quit unexpectedly due to a buffer-related error. More details can be found here: RangeError: err_buffer_out_of_bounds.
Example of Keychain Data:
Example of a Weapon with Keychain Data:
Thanks for the review!