Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difficulties in drawing generation. #45

Closed
sreekaribh opened this issue Apr 1, 2024 · 2 comments
Closed

Difficulties in drawing generation. #45

sreekaribh opened this issue Apr 1, 2024 · 2 comments

Comments

@sreekaribh
Copy link

Hello CsGoh,
The Processpiper library is working only for 4 connections irrespective of the incoming and outgoing paths. In my case, I have 5 connections for the single task [B] for which it is failing to draw. Regarding this issue I made few changes in the shape.py file [shortest_source_coord.connected = False] which is drawing fine but the two tasks [E, F] are overlapping after these changes. So, kindly guide me with solution. Please refer the diagram.
Screenshot 2024-04-01 164658

Thanks
@csgoh
Copy link
Owner

csgoh commented Apr 2, 2024

Hi @sreekaribh, the limit of 4 connection per element is by design. According to BPMN best practice, an element should be connected either left, right, top, or bottom. If you have more than 4 connections (incoming and outgoing), it is better to add another gateway element to fan out.

You can see the previously closed issue here: #17

Hope this helps.

@csgoh
Copy link
Owner

csgoh commented Jun 17, 2024

Closing the issue as there is no further response.

@csgoh csgoh closed this as completed Jun 17, 2024
csgoh pushed a commit that referenced this issue Jul 5, 2024
@chengsoongoh
### Adjust coordinate handling for BPMN shapes
0b20582 
Refined how `dc:Bounds` elements are generated for BPMN shapes. Specifically, `Start` and `End` shapes now have their coordinates adjusted based on their radius, enhancing their positioning accuracy.

Moreover, consolidated handling of connection points by using a unified list `connection_points`, streamlining waypoint generation and improving readability.

Fixes issue #45 regarding incorrect diagram renderings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csgoh @sreekaribh