fix(vips): fix label filter for grayscale images (#424)

* fix(vips): fix label filter for grayscale images * test: update golden files
cshum · Mar 27, 2024 · 42a08aa · 42a08aa
1 parent 912f5c5
commit 42a08aa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/testdata/golden/fit-in/filters%3Alabel%28imagor%2C-1%2C0%2C50%29/2bands.png b/testdata/golden/fit-in/filters%3Alabel%28imagor%2C-1%2C0%2C50%29/2bands.png
diff --git a/vips/filter.go b/vips/filter.go
@@ -385,7 +385,11 @@ func label(_ context.Context, img *Image, _ imagor.LoadFunc, args ...string) (er
 			font = args[6]
 		}
 	}
-	// make sure band equals 4
+	if img.Bands() < 3 {
+		if err = img.ToColorSpace(InterpretationSRGB); err != nil {
+			return
+		}
+	}
 	if err = img.AddAlpha(); err != nil {
 		return
 	}

diff --git a/vips/processor_test.go b/vips/processor_test.go
@@ -184,6 +184,7 @@ func TestProcessor(t *testing.T) {
 			{name: "label float", path: "fit-in/300x200/10x10/filters:fill(yellow):label(IMAGOR,-0.15,0.1,30,red,30)/gopher-front.png", arm64Golden: true},
 			{name: "label animated", path: "fit-in/150x200/10x00:10x50/filters:fill(yellow):label(IMAGOR,center,-30,25,black)/dancing-banana.gif", arm64Golden: true},
 			{name: "label animated with font", path: "fit-in/150x200/10x00:10x50/filters:fill(cyan):label(IMAGOR,center,-30,25,white,0,monospace)/dancing-banana.gif", arm64Golden: true},
+			{name: "label grayscale", path: "fit-in/filters:label(imagor,-1,0,50)/2bands.png", checkTypeOnly: true},
 			{name: "strip exif", path: "filters:strip_exif()/Canon_40D.jpg"},
 			{name: "bmp 24bit", path: "100x100/bmp_24.bmp"},
 			{name: "bmp 8bit", path: "100x100/lena_gray.bmp"},