controller: adds yaml to install and deploy controller #106
Conversation
|
@nixpanic @Rakshith-R please do add your reviews. Thanks, Rakshith for helping out with makefile. |
Makefile
Outdated
| manifests: controller-gen kustomize## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | ||
| $(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="{./api/...,./cmd/...,./controllers/...,./sidecar/...}" output:crd:artifacts:config=config/crd/bases | ||
| cd config/manager && $(KUSTOMIZE) edit set image controller=${CONTROLLER_IMG} $(KUSTOMIZE_RBAC_PROXY) | ||
| $(KUSTOMIZE) build config/default > deploy/controller/setup-controller.yaml |
There was a problem hiding this comment.
With this, yaml will be auto-generated whenever manifests is run and can be verified in the ci https://github.com/csi-addons/kubernetes-csi-addons/runs/4977203144?check_suite_focus=true#step:4:10
| $(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="{./api/...,./cmd/...,./controllers/...,./sidecar/...}" output:crd:artifacts:config=config/crd/bases | ||
| cd config/manager && $(KUSTOMIZE) edit set image controller=${CONTROLLER_IMG} $(KUSTOMIZE_RBAC_PROXY) | ||
| $(KUSTOMIZE) build config/default > deploy/controller/setup-controller.yaml |
There was a problem hiding this comment.
we should do kubectl dry-run to verify the template's syntax is correct.
| @@ -0,0 +1,1050 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
is it possible to have 3 files, one for CRD, one for RBAC, and one for deployment? 1050 lines in a single file seem heavy for me.
There was a problem hiding this comment.
Yeah, we can, but here we are just building the config/default which generates all these at a place. I would prefer to have it as a TODO as it requires more modifications.
| - --leader-elect | ||
| command: | ||
| - /manager | ||
| image: quay.io/csiaddons/k8s-controller:latest |
There was a problem hiding this comment.
hope this will get replaces when we do a release and release branch will contain the proper tagged image.
There was a problem hiding this comment.
So, its fine we do edit this in makefile. I created the file with this image. We can update it with latest build.
There was a problem hiding this comment.
This should probably become an artifact when we do a release. Creating a tag in git can then generate the yaml, and post it as part of the release (somehow). It requires adding one or more jobs to the build-push workflow we already have.
|
@Madhu-1 @nixpanic @Rakshith-R Let's go with one file for now. This file is auto-generated via Kustomize and splitting it breaks some or the other things. So I guess we can add a TODO in Makefile itself so that we can have the rook implementation done. Please do share your thoughts on this and will update the PR accordingly. |
Makefile
Outdated
| @@ -83,8 +83,10 @@ help: ## Display this help. | |||
| ##@ Development | |||
|
|
|||
| .PHONY: manifests | |||
| manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | |||
| manifests: controller-gen kustomize## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | |||
There was a problem hiding this comment.
use a space between kustomize##, not sure if this does what is intended
| - --leader-elect | ||
| command: | ||
| - /manager | ||
| image: quay.io/csiaddons/k8s-controller:latest |
There was a problem hiding this comment.
This should probably become an artifact when we do a release. Creating a tag in git can then generate the yaml, and post it as part of the release (somehow). It requires adding one or more jobs to the build-push workflow we already have.
this commit adds raw yaml generated using kustomize in deploy/controller/ which can be used by others to directly deploy the controller Fixes: csi-addons#105 Signed-off-by: yati1998 <ypadia@redhat.com>
mergify
bot
dismissed
Rakshith-R’s stale review
Pull request has been modified.
Syncing latest changes from upstream main for kubernetes-csi-addons
this commit adds raw yaml generated using kustomize
in deploy/crds.yaml which can be used by others to
directly deploy the controller
Fixes: #105
Signed-off-by: yati1998 ypadia@redhat.com