Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add golang modules for apis #381

Closed
wants to merge 1 commit into from

Conversation

subhamkrai
Copy link
Contributor

This change is beneficial to other projects that use kubernetes-csi-addons API and want to keep import dependency minimal. Importing API only reduces imported dependencies.

@mergify mergify bot added the vendor Pull requests that update vendored dependencies label Jun 23, 2023
@mergify mergify bot requested review from nixpanic, Rakshith-R and yati1998 June 23, 2023 10:06
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
apis/go.mod Outdated Show resolved Hide resolved
@subhamkrai subhamkrai force-pushed the add-api-go-mod branch 2 times, most recently from 5a8d8ed to 5dad0f7 Compare June 23, 2023 10:46
This commit updates the reconcile logic to
get more info and update the volrep status.

Signed-off-by: yati1998 <ypadia@redhat.com>
Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai
Copy link
Contributor Author

closing on favour of #382

@subhamkrai subhamkrai closed this Jun 23, 2023
@subhamkrai subhamkrai deleted the add-api-go-mod branch June 23, 2023 12:06
@subhamkrai subhamkrai restored the add-api-go-mod branch June 26, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor Pull requests that update vendored dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants