controller/pvc: add checks for nil/empty pvc.Spec.StorageClassName #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
black-dragon74,
iPraveenParihar,
Madhu-1,
nixpanic and
yati1998
Madhu-1
reviewed
Sep 24, 2024
| @@ -323,6 +323,15 @@ func TestDetermineScheduleAndRequeue(t *testing.T) { | |||
| assert.Equal(t, "", schedule) | |||
| }) | |||
|
|
|||
| // test for StorageClassName is nil | |||
| t.Run("StorageClassName is nil", func(t *testing.T) { | |||
| sc.Name = "non-existent-sc" | |||
There was a problem hiding this comment.
Can you pleas remove this line, This is not required for this testcase
Rakshith-R
force-pushed
the
fix-scName
branch
from
5bea61e to
92274e8
Compare
mergify
bot
dismissed
iPraveenParihar’s stale review
Pull request has been modified.
Madhu-1
approved these changes
Sep 24, 2024
iPraveenParihar
approved these changes
Sep 24, 2024
`pvc.Spec.StorageClassName` is a string pointer and can be nil or empty. This commit adds check for both nil and empty. Signed-off-by: Rakshith R <rar@redhat.com>
Rakshith-R
force-pushed
the
fix-scName
branch
from
92274e8 to
7c8ff92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pvc.Spec.StorageClassNameis a string pointer and can be nil or empty. This commit adds check for both nil and empty.