Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volumegroup: crd and doc updates for volumegroup replication #748

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha commented Jan 16, 2025

Added CRD changes and docs for the VGR and VGRContent CR.
P.S: This is smaller PR made out of of #610 for easier review.

@mergify mergify bot added the api Change to the API, requires extra care label Jan 16, 2025
docs/volumegroupreplication.md Outdated Show resolved Hide resolved
docs/volumegroupreplication.md Outdated Show resolved Hide resolved
docs/volumegroupreplication.md Outdated Show resolved Hide resolved
docs/volumegroupreplication.md Show resolved Hide resolved
updated CRDs, fixed typos for volumegroupreplication

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
@Nikhil-Ladha
Copy link
Contributor Author

@Madhu-1 @nixpanic I have taken care of all the reviews, please take a look again when you get some time.

Madhu-1
Madhu-1 previously approved these changes Jan 17, 2025
Copy link
Collaborator

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the examples don't have matching labels, everything else looks good 👍

docs/volumegroupreplication.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed Madhu-1’s stale review January 17, 2025 11:20

Pull request has been modified.

@Nikhil-Ladha Nikhil-Ladha requested a review from nixpanic January 17, 2025 11:20
docs/volumegroupreplication.md Outdated Show resolved Hide resolved
add docs VolumeGroupReplication and VolumeGroupReplicationContent

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Copy link
Collaborator

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nixpanic nixpanic requested a review from Madhu-1 January 17, 2025 13:27
@mergify mergify bot merged commit 4958462 into csi-addons:main Jan 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Change to the API, requires extra care
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants