-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
volumegroup: crd and doc updates for volumegroup replication #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10ce2c6
to
795d890
Compare
nixpanic
reviewed
Jan 16, 2025
api/replication.storage/v1alpha1/volumegroupreplicationcontent_types.go
Outdated
Show resolved
Hide resolved
795d890
to
94f2ea8
Compare
Madhu-1
reviewed
Jan 16, 2025
94f2ea8
to
ad06e9c
Compare
updated CRDs, fixed typos for volumegroupreplication Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
ad06e9c
to
548fff2
Compare
Madhu-1
previously approved these changes
Jan 17, 2025
nixpanic
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the examples don't have matching labels, everything else looks good 👍
548fff2
to
05324d8
Compare
nixpanic
requested changes
Jan 17, 2025
add docs VolumeGroupReplication and VolumeGroupReplicationContent Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
05324d8
to
1d2e287
Compare
nixpanic
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Madhu-1
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CRD changes and docs for the VGR and VGRContent CR.
P.S: This is smaller PR made out of of #610 for easier review.