Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points added to multiple waterbodies due to error margins #52

Open
oehm-smith opened this issue Mar 5, 2020 · 1 comment
Open

Points added to multiple waterbodies due to error margins #52

oehm-smith opened this issue Mar 5, 2020 · 1 comment
Labels

Comments

@oehm-smith
Copy link
Collaborator

Commit 5.3.20 - On Lake Burley Griffin, there is one point to the east of lake that is included in 2
pie graphs. That seems to be because the point itself is in LBG but one error margin point is in a different waterbody (that looks like a hole in the LBG polygon).

The algorithm to fix needs to be along the line of "if source point is in a water body then don't use error margin points to test if in waterbody".

oehm-smith added a commit that referenced this issue Mar 5, 2020
* Lake Burley Griffin had 3 pie charts in it, maybe more.  This change
prevents that
* Although you will see a 2nd pie chart for the one point to the east. As per
#52
this is due to the error margins
@oehm-smith
Copy link
Collaborator Author

I'm deferring work on this and may never actually do. The work log entry i added to __ says:

  • This is a tough problem and I don't know it is worth the effort
  • The problem is in calculateLayerIntersections(). The intersection
    is all points (source and errorMargin). But the uses of an EMP and SP
    spans across polygons (by definition of this problem - if in the same
    polygon GisOps.filterSourcePoints leaves only SPs). So the filtering
    needs to be moved to be across polygons. AND the order might be different
  • the EMP could be added first or the SP could be added first

@oehm-smith oehm-smith added the hard label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant