Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile Backend Models #399

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

adit-bala
Copy link
Member

No description provided.

@cypress
Copy link

cypress bot commented Feb 28, 2023

Passing run #85 ↗︎

0 78 0 0 Flakiness 0

Details:

User Profile Backend Models
Project: csm_web Commit: c73e7eb841
Status: Passed Duration: 02:29 💡
Started: Feb 28, 2023 4:00 AM Ended: Feb 28, 2023 4:03 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

if is_private is not None:
user.is_private = is_private
user.save()
return Response(status=status.HTTP_201_CREATED)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this shouldn't be a 201 CREATED, since you haven't actually created anything. Likely a 200 OK or a ``202 ACCEPTED` would likely fit better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sir

- refactored `userinfo` route to update user profile
- created userprofile url to get a user's profile with an `user_id`
- more correct logic!
Copy link
Member

@smartspot2 smartspot2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is dominated by whitespace (EOL) changes; I'd recommend trying to resolve this before merging, as it'll make the actual diff a lot harder to view on GitHub.

Perhaps look at git documentation on line endings, or look at line ending configuration in your editor, and tweak configuration settings until modifications to files do not cause all line endings to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants