-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use configure_file for Perl files #155
base: master
Are you sure you want to change the base?
Conversation
Solves the problem that the creduce executable was not regenerated everytime creduce.in changed.
Thank you for this patch! I will review it. |
Yes, thanks, this is great. I looked at the changes and see no problems, but my CMake is not strong. |
Anything blocking this? I ran cmake with and without my changes and got no difference between the two variants if that helps. ;-) |
I am going to make a new release of C-Reduce before I consider this pull request. |
I tried this on my Mac this morning. If I tweak But if I just remove I guess this is OK, but it is sort of un- I am using CMake 3.11.4. |
Weird. Anyhow this seems like an improvement and it sounds like we should merge. |
Mhh, ok. I'll try to have a look next week. Maybe that can be fixed as well. |
At least part of the problem might be a bug in CMake itself. I filed an issue here: https://gitlab.kitware.com/cmake/cmake/issues/18218. I'll keep an eye on it and let you know about it's progress. Feel free to merge this PR in the meantime if you want. Or we wait until we know more about the outcome of the CMake issue. |
Solves the problem that the creduce executable was not regenerated
everytime creduce.in changed.