Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options have no effect on run selected? #50

Closed
Eistroll opened this issue May 2, 2016 · 12 comments
Closed

Options have no effect on run selected? #50

Eistroll opened this issue May 2, 2016 · 12 comments

Comments

@Eistroll
Copy link

Eistroll commented May 2, 2016

Hi there
I have disabled break on failure and enabled catch exceptions in the options but when I invoke "Run selected test" the options are not used.
Executing command 'base_test.exe --gtest_output="xml:C:\Users\thomas.roller\AppData\Local\Temp\tmp7548.tmp" --gtest_catch_exceptions=0 --gtest_break_on_failure=1 --gtest_filter=TestCOPManagerIterator.BackwardBasics'

Am I doing something wrong?

@Eistroll Eistroll changed the title Options have no effect on debug run? Options have no effect on run selected? May 2, 2016
@csoltenborn
Copy link
Owner

csoltenborn commented May 3, 2016

Nothing that I can think of. I didn't have time to try to reproduce this yet - can you please try to configure your settings, restart VS, and then try again without changing the settings after restart? Maybe it's a refresh issue... And here's some more questions: Do you have Test/Test Settings/Keep test execution engine running enabled? Is this also happening if you change the options through the adapter's toolbar? And finally: Does it always work if you Run all tests?

@csoltenborn csoltenborn added the bug label May 3, 2016
@Eistroll
Copy link
Author

Eistroll commented May 3, 2016

  • Test/Test Settings/Keep test execution engine running enabled? Is on but has no influence if I turn it off.
  • No difference if I use toolbar.
  • If I use the filter of the test explorer and make Run all then it also does not work

When I restart VS then it uses the options so it seems to be a refresh issue

@csoltenborn
Copy link
Owner

We have just finished our first debug session on this issue, and it looks like the VS test execution engine only asks our run settings service for fresh settings if "Run All" (without any filter) is clicked. This is just weird - we are pretty sure that in the past, the test execution engine would ask for fresh settings at every test run, no matter whether a selection of tests or all tests were executed.

Currently, this looks like a regression in VS. We see two "workarounds":

  • Always use "Run all tests"
  • Restart VS after changing options of our test adapter

Both workarounds obviously suck big time :-(

We will now try to figure out the VS version at which that behavior has changed, and also if it is an VS API change (the test adapter API is not official, so we have to figure all that stuff out on our own) - obviously, MS has worked on the test framework (see the new "Run tests in parallel" button), so maybe this is new behavior to which we have to adapt.

If you want to help, and if you happen to have access to VS 2015 without updates or VS 2015 with just Update 1, please let us know whether our options still work with one of these versions.

@Eistroll
Copy link
Author

Eistroll commented May 4, 2016

I am sorry. We only have VS2015 with Update 2 around here...

@csoltenborn
Copy link
Owner

I had the chance to try different VS versions today. Here's the thing: It works just fine on VS Enterprise Edition 2015 without update, with update 1, and with update 2.

Thus, it seems that the problem only occurs with the Community Edition and (possibly) the Professional Edition.

@Eistroll Can you confirm that you are not using the Enterprise Edition?

If this is indeed the case, the only thing we can probably do about this issue is filing a bug report against the affected VS editions - it currently doesn't look like it's our fault...

On the plus side, I think that I have found a slightly better workaround: Close and re-open your solution. This apparently also triggers reloading of the settings. Still not nice at all, but better than the other workarounds we suggested.

@csoltenborn
Copy link
Owner

@Eistroll Which VS edition are you guys using? I assume it's not the Enterprise edition?

@Eistroll
Copy link
Author

Hi Christian,
we are using VS 2015 Professional and no Enterprise edition

@csoltenborn
Copy link
Owner

csoltenborn commented May 25, 2016

I have reported the problem to MS, here's the bug report. Feel free to add more information at that place as needed... (and maybe vote for the bug).

@csoltenborn
Copy link
Owner

Looks like our assumption was right - the bug has been closed with the comment that this will be fixed with update 3. Thanks, @Eistroll, for reporting this!

@Eistroll
Copy link
Author

Thanks for the info and investigating it.

@csoltenborn
Copy link
Owner

@Eistroll The release candidate for VS update 3 has been released, and seems to have fixed the issue (at least on Community edition) - depending on how badly the regression hurts you guys, you may want to install it already.

@Eistroll
Copy link
Author

Hi there,

thanks for the information, but I think we will wait :-)

On Thu, Jun 16, 2016 at 6:30 PM, Christian Soltenborn <
notifications@github.com> wrote:

@Eistroll https://github.com/Eistroll The release candidate for VS
update 3 has been released
https://www.visualstudio.com/en-us/news/releasenotes/vs2015-update3-vs,
and seems to have fixed the issue (at least on Community edition) -
depending on how badly the regression hurts you guys, you may want to
install it already.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#50 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AQXgYiUloHcmi9WsastfySHPMiQJQjXtks5qMXoZgaJpZM4IVKMr
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants