Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#106 remove old execution framework #115

Closed
wants to merge 10 commits into from

Conversation

csoltenborn
Copy link
Owner

Removed the old execution framework, plus some follow-up refactorings

@codecov-io
Copy link

codecov-io commented Feb 27, 2017

Codecov Report

Merging #115 into develop will increase coverage by 1.82%.
The diff coverage is 95.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #115      +/-   ##
===========================================
+ Coverage    73.01%   74.84%   +1.82%     
===========================================
  Files           76       67       -9     
  Lines         2913     2667     -246     
  Branches       427      384      -43     
===========================================
- Hits          2127     1996     -131     
+ Misses         637      542      -95     
+ Partials       149      129      -20
Flag Coverage Δ
#Integration 62.89% <85.92%> (+5%) ⬆️
#Unit 53.76% <62.59%> (+0.38%) ⬆️
Impacted Files Coverage Δ
GoogleTestAdapter/Core/Settings/SettingsWrapper.cs 88.88% <ø> (+0.69%) ⬆️
...dapter/VsPackage/GoogleTestExtensionOptionsPage.cs 0% <ø> (ø) ⬆️
...VsPackage/OptionsPages/GeneralOptionsDialogPage.cs 0% <ø> (ø) ⬆️
...dapter/Core/Settings/IGoogleTestAdapterSettings.cs 26.92% <ø> (+0.99%) ⬆️
GoogleTestAdapter/TestAdapter/CommonFunctions.cs 20.68% <ø> (ø) ⬆️
...dapter/TestAdapter/Framework/VsDebuggerAttacher.cs 0% <ø> (ø) ⬆️
GoogleTestAdapter/Core/Settings/RunSettings.cs 87.3% <ø> (-0.4%) ⬇️
GoogleTestAdapter/Core/Helpers/Extensions.cs 100% <ø> (ø) ⬆️
...oogleTestAdapter/Core/Settings/RegexTraitParser.cs 100% <ø> (ø)
...ter/TestAdapter/Framework/VsTestFrameworkLogger.cs 85.18% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1447ea...58291d2. Read the comment docs.

# Conflicts:
#	GoogleTestAdapter/Core.Tests/Core.Tests.csproj
#	GoogleTestAdapter/Core.Tests/Helpers/UtilsTests.cs
#	GoogleTestAdapter/Core/GoogleTestDiscoverer.cs
#	GoogleTestAdapter/Core/Runners/ParallelTestRunner.cs
#	GoogleTestAdapter/Core/TestCases/TestCaseFactory.cs
#	GoogleTestAdapter/TestAdapter/TestExecutor.cs
# Conflicts:
#	GoogleTestAdapter/Core.Tests/TestResults/StandardOutputTestResultParserTests.cs
#	GoogleTestAdapter/Core.Tests/TestResults/StreamingTestOutputParserTests.cs
#	GoogleTestAdapter/Core/Runners/SequentialTestRunner.cs
#	GoogleTestAdapter/Core/TestResults/StandardOutputTestResultParser.cs
#	GoogleTestAdapter/Core/TestResults/StreamingStandardOutputTestResultParser.cs
@csoltenborn
Copy link
Owner Author

Closing this for now, since #124 and #126 have priority, and we have to investigate performance problems before completely removing old test execution framework.

csoltenborn pushed a commit that referenced this pull request Jan 24, 2018
* silence tr1 namespace issues though cmake

* add preprocessor def to fix tr1 failures when building tests
csoltenborn pushed a commit that referenced this pull request Aug 4, 2018
* silence tr1 namespace issues though cmake

* add preprocessor def to fix tr1 failures when building tests
@csoltenborn csoltenborn deleted the #106_RemoveOldExecutionFramework branch December 9, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants