This is the pull Request for Issue 21 (Updating Readme with specific MacOS instructions) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneeshs1729
changed the title
This is for Issue21; Updated the MacOS Makefile instructions
pritkc
requested changes
Dec 16, 2024
Comment on lines
+71
to
+72
| To use MOLE (C++ version), you need to have _Armadillo C++_ <http://arma.sourceforge.net>, _SuperLU_ | ||
| <https://portal.nersc.gov/project/sparse/superlu>, and _OpenBLAS_ <https://www.openblas.net> installed on your computer. |
There was a problem hiding this comment.
We can try to avoid this redundancy (ref. 3: Installation (Linux))
|
|
||
| On Macs, you can install superlu using the following steps: | ||
| a. Open a terminal | ||
| b. (type) brew install superlu |
There was a problem hiding this comment.
A code markdown might suit better
i.e brew install superlu
Comment on lines
+89
to
+93
| ifdef SUPERLU | ||
| LIBS += -L$(SUPERLU)/lib -Wl,-rpath,$(SUPERLU)/lib -lsuperlu -L/opt/homebrew/Cellar/superlu/7.0.0/lib | ||
| else | ||
| LIBS += -lsuperlu -L/opt/homebrew/Cellar/superlu/7.0.0/lib | ||
| endif |
There was a problem hiding this comment.
ifdef SUPERLU
LIBS += -L$(SUPERLU)/lib -Wl,-rpath,$(SUPERLU)/lib -lsuperlu -L/opt/homebrew/Cellar/superlu/7.0.0/lib
else
LIBS += -lsuperlu -L/opt/homebrew/Cellar/superlu/7.0.0/lib
endif
| else | ||
| LIBS += -lsuperlu -L/opt/homebrew/Cellar/superlu/7.0.0/lib | ||
| endif | ||
| 3. Add the path to openblas namely -L/opt/homebrew/opt/openblas/lib as shown below |
There was a problem hiding this comment.
-L/opt/homebrew/opt/openblas/lib
| 3. Add the path to openblas namely -L/opt/homebrew/opt/openblas/lib as shown below | ||
| LIBS = -L$(MOLE) -lmole -lopenblas -L/opt/homebrew/opt/openblas/lib | ||
|
|
||
| As mentioned in the Linux instllation above, do the following steps as usual - |
There was a problem hiding this comment.
Please inherit a summary or a reference here so that users don't have to sift through all the Linux installation steps.
| you may encounter difficulties in compiling. Follow the instructions given in section 3.0 above. If you are unable to compile, use the following command | ||
|
|
||
| To compile the source code in mole/src/mole_C++/ | ||
| - make CXX=g++-14 CC=gcc-14 |
| Another quriky change is the usage of makefiles on mac. Depending on the version of the software packages installed on your mac, | ||
| you may encounter difficulties in compiling. Follow the instructions given in section 3.0 above. If you are unable to compile, use the following command | ||
|
|
||
| To compile the source code in mole/src/mole_C++/ |
There was a problem hiding this comment.
To compile the source code in src/cpp or examples/cpp {*or src/src/mole_C++}:
make CXX=g++-14 CC=gcc-14
- Please verify the path here, as I am not entirely sure about the default path for the example test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for Issue21; Updated the MacOS Makefile instructions