PR for partial fix for Issue 20 (Added helper function) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a helper function to calculate the interior row for a kth order mimetic operator for large k. which partially solves 20
valeriabarra
reviewed
Dec 9, 2024
src/cpp/utils.h
Outdated
|
|
||
| /** | ||
| * @brief Calculates the interior row for the kth order central finite difference scheme. This is in utils because | ||
| *Both the gradient and interior operators need to use this for large k |
There was a problem hiding this comment.
I think you need a space here to render this via Doxygen doc, i.e.,
Suggested change
| *Both the gradient and interior operators need to use this for large k | |
| * Both the gradient and interior operators need to use this for large k |
…n it. Added documentation that the way my kthordercentraldiff function works is that it writes the second order interior operator, delta_h(f)=(f(x+h/2)-f(x-h/2))/h=(2*sinh(h/2*d/dx))/(h)*f. And then doing formal power series inversion to get d/dx out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a helper function to calculate the interior row for a kth order mimetic operator for large k. which partially solves 20