Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composes duplicates dependancies #58

Closed
themitchy opened this issue Nov 9, 2015 · 4 comments
Closed

composes duplicates dependancies #58

themitchy opened this issue Nov 9, 2015 · 4 comments

Comments

@themitchy
Copy link

If multiple stylesheets are imported (or components importing different stylesheets) and those files compose from a common stylesheet (ie. icons.css) then the styles and composes of the common stylesheet will be duplicated for every import.

This gist shows a simple jsx which imports 2 modules, each of which imports a stylesheet composing from icons.css. Since icons.css composes from font-awesome, all of font-awesome is included in the resulting css twice.

@loklaan
Copy link
Contributor

loklaan commented Nov 9, 2015

Could you try out #57, which should resolve this issue.

@themitchy
Copy link
Author

No dice on #57 - still results in dupes of everything in the common stylesheet.

@joshwnj
Copy link
Member

joshwnj commented Nov 20, 2015

@themitchy please take a look at #61 to see whether that fixes the issue.

@themitchy
Copy link
Author

That did it! Thanks @joshwnj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants