Add matches, querySelector, querySelectorAll to DOM, and the KEY_SVG_SELECTOR transcoding hint
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `KEY_SVG_SELECTOR` is set and the document is HTML, its value as a CSS selector is used to locate the element that will be used as the SVG root. In the case of the transcoding helper, if the selector argument is null then `KEY_SVG_SELECTOR` is used, and if also null then the previous behaviour follows. This new hint is part of the effort to make EchoSVG friendly to embedded SVG images. See also: #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
matches(),querySelector()andquerySelectorAll()Add the
KEY_SVG_SELECTORtranscoding hintIf
KEY_SVG_SELECTORis set and the document is HTML, its value as a CSS selector is used to locate the element that will be used as the SVG root.In the case of the transcoding helper, if the selector argument is null then
KEY_SVG_SELECTORis used, and if also null then the previous behaviour follows.If you come up with a better name for
KEY_SVG_SELECTOR, please comment here.This new hint is part of the effort to make EchoSVG friendly to embedded SVG images, see #40.