[react-jss] Fix display names with spaces inside #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
reviewed
Mar 5, 2019
packages/react-jss/src/withStyles.js
Outdated
| @@ -65,7 +65,8 @@ export default function withStyles<Theme: {}, S: Styles<Theme>>( | |||
| InnerComponent: ComponentType<Props> = NoRenderer | |||
| ): ComponentType<Props> => { | |||
| const displayName = getDisplayName(InnerComponent) | |||
| const defaultClassNamePrefix = process.env.NODE_ENV === 'production' ? '' : `${displayName}-` | |||
| const defaultClassNamePrefix = | |||
| process.env.NODE_ENV === 'production' ? '' : `${displayName.replace(/\s/, '-')}-` | |||
There was a problem hiding this comment.
- we should match all spaces, not just one, global flag is missing
- lets add a test
kof
approved these changes
Mar 6, 2019
|
changelog 😱 |
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
* Fix display names with spaces inside * Add test and replace all spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would you like to add/fix?
Replaces any whitespaces in a components display name with
-.Corresponding issue: #938