Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udpate ts typings #1155

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Udpate ts typings #1155

merged 4 commits into from
Jul 11, 2019

Conversation

HenriBeck
Copy link
Member

@HenriBeck HenriBeck commented Jul 6, 2019

What would you like to add/fix?
Update TS types

Corresponding issue (if exists):
Closes #1132
Closes #1114

Henri Beck added 2 commits June 9, 2019 15:26
* master: (50 commits)
  v10.0.0-alpha.22
  add react-dom dev dependenncy
  Fix SSR for Hooks based implementation (#1148)
  React-JSS id prop docs and improvements (#1147)
  v10.0.0-alpha.21
  fix changelog
  add support hint to the changelog (#1145)
  Sheets management for css() (#1137)
  Update css-vendor to 2.0.5 (#1142)
  more articles
  Small readability improvements (#1138)
  create sponsors.md (#1139)
  update karma settings
  Update css-vendor to 2.0.4 (#1136)
  v10.0.0-alpha.20
  fixing release
  v10.0.0-alpha.19
  fix lerna force-publish flag
  many more tests and some improvements to styped interface (#1133)
  v10.0.0-alpha.18
  ...

# Conflicts:
#	packages/react-jss/src/index.d.ts
@HenriBeck HenriBeck requested a review from kof July 6, 2019 17:22
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if csstype needs to be direct dependency

@kof
Copy link
Member

kof commented Jul 7, 2019

don't forget the changelog

@peku33
Copy link

peku33 commented Jul 10, 2019

Any update on this?

@HenriBeck HenriBeck merged commit 2cb3fee into master Jul 11, 2019
bhupinderbola pushed a commit to bhupinderbola/jss that referenced this pull request Sep 17, 2019
* Add types for createUseStyles and improve Style type

* Add string support for createUseStyles

* Update changelog
@iamstarkov iamstarkov deleted the udpate-ts-typings branch October 4, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants