Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add px as default unit for row-gap property #1436

Merged
merged 1 commit into from
Dec 26, 2020
Merged

feat: add px as default unit for row-gap property #1436

merged 1 commit into from
Dec 26, 2020

Conversation

VineethK336
Copy link
Contributor

Corresponding issue (if exists):

#1435

What would you like to add/fix?

Adds default unit as px for row-gap css property

Todo

  • Add tests if possible
  • Add changelog if users should know about the change
  • Add documentation

@kof
Copy link
Member

kof commented Dec 26, 2020

lgtm, thanks

@kof kof merged commit c4d4deb into cssinjs:master Dec 26, 2020
@VineethK336 VineethK336 deleted the add-default-unit-for-row-gap-property branch December 26, 2020 17:21
@VineethK336
Copy link
Contributor Author

That was lightning fast response! Happy to help! :)

@kof
Copy link
Member

kof commented Jan 23, 2021

Released https://github.com/cssinjs/jss/releases/tag/v10.5.1

This was referenced Mar 15, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenriBeck HenriBeck Awaiting requested review from HenriBeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VineethK336 @kof