Move react-jss types to dev dependencies #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
reviewed
Jan 20, 2019
| "hoist-non-react-statics": "^3.2.0", | ||
| "jss": "^10.0.0-alpha.8", | ||
| "jss-preset-default": "^10.0.0-alpha.8", | ||
| "prop-types": "^15.6.0", | ||
| "theming": "^3.0.2" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
what about additionally having them in peerDependencies?
There was a problem hiding this comment.
This would require everyone to install them 🤔
Or if they don't decide on installing them, they will constantly have a warning for a missing peer dependency which isn't nice either
There was a problem hiding this comment.
yeah, how do we ensure that userr gets the right version of typings with a version of JSS?
There was a problem hiding this comment.
The things which we are using from react are also not to special/new so I don't think we will have a problem with that.
There was a problem hiding this comment.
The definetly typed version also has no dependency on react types package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would you like to add/fix?
Installing external types can have a problem when the end user also installs the same types package.
As we shouldn't force someone to install the @types/react package, I just moved to the dev dependencies. I think we can expect someone to have the appropriate package installed when using
react-jssand using typescriptCorresponding issue (if exists): #976