-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design tokens #304
design tokens #304
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…ionate-sponge-94364bcfba
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…ec--diligent-somali-ba407e5bb5
…ionate-sponge-94364bcfba
plugins/postcss-design-tokens/src/data-formats/style-dictionary/v3/value.ts
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
|
||
All `@design-tokens` rules are evaluated before any `design-token()` functions. | ||
|
||
`@design-tokens` rules can be conditional through `when` conditions. Multiple values can be specified in `when`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a comment that specifies that when multiple it means AND
, not OR
? Or something as in, all conditions must be met?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this bit :
Multiple conditions always have an
AND
relationship.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
see : #192
see : #151
Notice :
A lot has changed since the initial pull request was opened.
I have hidden all comments as they likely no longer apply.
The README in this pull request illustrates the current design direction
Current approach aims to support multiple token file formats side by side.
Will also heavily lean on IDE support for ergonomics.