Improve performance of control comments in postcss-custom-properties
#737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marvin Hagemeister <hello@marvinh.dev>
Antonio-Laguna
approved these changes
Nov 30, 2022
romainmenke
deleted the
custom-props--perf--sympathetic-pond-skater-e2e4815efd
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #730
@marvinhagemeister After discussing this with @Antonio-Laguna we decided to keep the functionality but to improve performance sufficiently.
We found that the performance issue only happens in fairly large code bases with large numbers of custom properties.
This change has three parts :
html/:rootelementsWeakMap.With these changes the overhead of the feature becomes negligible.
O(n^2)->O(n)