Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency doorkeeper to v5.6.6 [security] #422

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 28, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
doorkeeper (changelog) 5.5.4 -> 5.6.6 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-34246

OAuth RFC 8252 says https://www.rfc-editor.org/rfc/rfc8252#section-8.6

the authorization server SHOULD NOT process authorization requests automatically without user consent or interaction, except when the identity of the client can be assured. This includes the case where the user has previously approved an authorization request for a given client id

But Doorkeeper automatically processes authorization requests without user consent for public clients that have been previously approved. Public clients are inherently vulnerable to impersonation, their identity cannot be assured.

Issue https://github.com/doorkeeper-gem/doorkeeper/issues/1589

Fix https://github.com/doorkeeper-gem/doorkeeper/pull/1646


Release Notes

doorkeeper-gem/doorkeeper (doorkeeper)

v5.6.6

Compare Source

  • [#​1644] Update HTTP headers.
  • [#​1646] Block public clients automatic authorization skip.
  • [#​1648] Add custom token attributes to Refresh Token Request.
  • [#​1649] Fixed custom_access_token_attributes related errors.

v5.6.5

Compare Source

  • [#​1602] Allow custom data to be stored inside access grants/tokens.
  • [#​1634] Code refactoring for custom token attributes.
  • [#​1639] Add grant type validation to avoid Internal Server Error for DELETE /oauth/authorize endpoint.

v5.6.4

Compare Source

  • [#​1633] Apply ORM configuration in #to_prepare block to avoid autoloading errors.

v5.6.3

Compare Source

  • [#​1622] Drop support for Rubies 2.5 and 2.6
  • [#​1605] Fix URI validation for Ruby 3.2+.
  • [#​1625] Exclude endless access tokens from StaleRecordsCleaner.
  • [#​1626] Remove deprecated active_record_options config option.
  • [#​1631] Fix regression with redirect behavior after token lookup optimizations (redirect to app URI when found).
  • [#​1630] Special case unique index creation for refresh_token on SQL Server.
  • [#​1627] Lazy evaluate Doorkeeper config when loading files and executing initializers.

v5.6.2

Compare Source

  • [#​1604] Fix fetching of the application when custom application_class defined.

v5.6.1

Compare Source

  • [#​1593] Add support for Trilogy ActiveRecord adapter.
  • [#​1597] Add optional support to use the url path for the native authorization code flow. Ports forward [#​1143] from 4.4.3
  • [#​1599] Remove unnecessarily re-fetch of application object when creating an access token.

v5.6.0

Compare Source

  • [#​1581] Consider token_type_hint when searching for access token in TokensController to avoid extra database calls.

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 28, 2024
@renovate renovate bot force-pushed the renovate/rubygems-doorkeeper-vulnerability branch 7 times, most recently from 58df889 to 56f1262 Compare October 26, 2024 19:35
@renovate renovate bot force-pushed the renovate/rubygems-doorkeeper-vulnerability branch from 56f1262 to 086ec3a Compare November 3, 2024 10:47
@renovate renovate bot force-pushed the renovate/rubygems-doorkeeper-vulnerability branch from 086ec3a to 9f147de Compare November 11, 2024 15:10
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (fc879bc) to head (6f6a6c7).
Report is 2 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #422   +/-   ##
========================================
  Coverage    99.92%   99.92%           
========================================
  Files          203      203           
  Lines         2714     2714           
========================================
  Hits          2712     2712           
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@renovate renovate bot force-pushed the renovate/rubygems-doorkeeper-vulnerability branch 2 times, most recently from 19e7fa1 to 17e95d1 Compare November 22, 2024 01:00
@lodewiges lodewiges added this pull request to the merge queue Nov 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 22, 2024
@renovate renovate bot force-pushed the renovate/rubygems-doorkeeper-vulnerability branch from 17e95d1 to 6f6a6c7 Compare November 22, 2024 09:57
@lodewiges lodewiges added this pull request to the merge queue Nov 22, 2024
Merged via the queue into staging with commit acf5061 Nov 22, 2024
5 checks passed
@lodewiges lodewiges deleted the renovate/rubygems-doorkeeper-vulnerability branch November 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file status:ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant