Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comment to improve ULs calculation in post DL3 analysis #1318

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

morcuended
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@morcuended morcuended marked this pull request as draft November 25, 2024 16:47
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.52%. Comparing base (8a62ad1) to head (8d783cd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1318   +/-   ##
=======================================
  Coverage   73.52%   73.52%           
=======================================
  Files         134      134           
  Lines       14215    14215           
=======================================
  Hits        10451    10451           
  Misses       3764     3764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

moralejo
moralejo previously approved these changes Dec 19, 2024
@moralejo
Copy link
Collaborator

Hi @morcuended, is this completed or do you need to add anything else? If not, please un-draft.

@morcuended morcuended marked this pull request as ready for review January 8, 2025 15:10
@morcuended
Copy link
Member Author

Hi @morcuended, is this completed or do you need to add anything else? If not, please un-draft.

Now it is ready for review.

@moralejo moralejo merged commit d8d30dd into main Jan 8, 2025
6 checks passed
@moralejo moralejo deleted the update_post_dl3_nb branch January 8, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants