Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file is not included as input in activity provenance #2313

Closed
maxnoe opened this issue Apr 21, 2023 · 2 comments · Fixed by #2312
Closed

Config file is not included as input in activity provenance #2313

maxnoe opened this issue Apr 21, 2023 · 2 comments · Fixed by #2312
Labels
Milestone

Comments

@maxnoe
Copy link
Member

maxnoe commented Apr 21, 2023

Describe the bug

Starting the training tool, I noticed this logging warning (recently added in #2261):

2023-03-10 18:50:33,179 INFO [ctapipe.ctapipe-train-energy-regressor] (tool.initialize): Loading config from '[PosixPath('/home/mnoethe/Uni/CTA/2023-03-22-dpg-ctapipe/config/train_energy_regressor.yml')]'
2023-03-10 18:50:33,196 WARNING [ctapipe.core.provenance] (provenance._get_current_or_start_activity): No activity has been started yet. Provenance().start_activity(<name>) should be called explicitly.

Investigating, I saw that start_activity is called in Tool.run after the call to initialize, which loads the config. So the config was assigned to the wrong activity and thus not written to the right activity provenance in the provenance log.

@maxnoe maxnoe added the bug label Apr 21, 2023
@kosack
Copy link
Contributor

kosack commented May 12, 2023

I believe this can be closed as it was fixed in a previous PR. Running it now, I do not get this message and the config is in the provenance log as expected:

ctapipe-process.provenance.log

4806   │       "input": [
4807   │          {
4808   │             "url": "/Users/kkosack/Projects/CTA/PipeWork/ml_preprocessing_config.yaml",
4809   │             "role": "Tool Configuration"
4810   │          },
4811   │          {
4812   │             "url": "/Users/kkosack/Data/CTA/Prod6_preliminary/gamma_prod6_preliminary.simtel.zst",
4813   │             "role": "DL0/Event"
4814   │          }
4815   │       ],

@kosack kosack closed this as completed May 12, 2023
@maxnoe
Copy link
Member Author

maxnoe commented May 12, 2023

Yes, sorry, I missed to make the correct connection, this was addressed in #2312

@maxnoe maxnoe added this to the v0.19.1 milestone May 12, 2023
@maxnoe maxnoe linked a pull request May 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants