Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activity start order #2312

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Fix activity start order #2312

merged 2 commits into from
Apr 21, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Apr 20, 2023

By not starting the activity before calling initialize,
an extra activity was started only containing the config files
and the config files were not included in the provenance of the actual
tool run.

@maxnoe maxnoe force-pushed the fix_activity_start_order branch from 916ad39 to c8d1d3b Compare April 20, 2023 14:52
By not starting the activity before calling initialize,
an extra activity was started only containing the config files
and the config files were not included in the provenance of the actual
tool run.
@maxnoe maxnoe force-pushed the fix_activity_start_order branch from c8d1d3b to 3822db3 Compare April 20, 2023 15:10
kosack
kosack previously approved these changes Apr 20, 2023
@maxnoe
Copy link
Member Author

maxnoe commented Apr 20, 2023

Tests were failing because the Provenance() includes (correctly) all previously run tools. So the correct activity too look at is the last, not the first one in the provlog

@kosack kosack merged commit 779ef88 into main Apr 21, 2023
@kosack kosack deleted the fix_activity_start_order branch April 21, 2023 10:26
@maxnoe maxnoe added this to the v0.19.1 milestone May 8, 2023
@maxnoe maxnoe linked an issue May 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config file is not included as input in activity provenance
3 participants