Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix set_line_hillas #2134

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

StFroese
Copy link
Member

No description provided.

@StFroese StFroese requested review from kosack and maxnoe November 23, 2022 17:37
@StFroese StFroese linked an issue Nov 23, 2022 that may be closed by this pull request
@StFroese
Copy link
Member Author

fix #2131

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 92.74% // Head: 92.74% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (03d320c) compared to base (8004264).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
- Coverage   92.74%   92.74%   -0.01%     
==========================================
  Files         214      214              
  Lines       17914    17911       -3     
==========================================
- Hits        16615    16612       -3     
  Misses       1299     1299              
Impacted Files Coverage Δ
ctapipe/tools/tests/test_process_ml.py 100.00% <ø> (ø)
ctapipe/conftest.py 94.58% <100.00%> (+0.31%) ⬆️
ctapipe/tools/apply_models.py 96.38% <100.00%> (+0.13%) ⬆️
ctapipe/tools/tests/test_apply_models.py 100.00% <100.00%> (ø)
ctapipe/tools/tests/test_train.py 100.00% <100.00%> (ø)
ctapipe/visualization/mpl_array.py 99.24% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxnoe maxnoe merged commit 982793a into cta-observatory:master Nov 24, 2022
@StFroese StFroese deleted the set_line_hillas_fix branch November 24, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_line_hillas should work in other frames
3 participants