Fix HillasIntersection error for badly reconstructed events #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Feb 22, 2023
ctapipe/reco/hillas_intersection.py
Outdated
| # Catch events reconstructed at great angular distance from camera center | ||
| # and retrun INVALID container to prevent SkyCoord error below. | ||
| if ( | ||
| np.abs(src_fov_lat) * u.rad > 45 * u.deg |
There was a problem hiding this comment.
I'd define the 45 ° limit in a named constant on top, something like FOV_ANGULAR_DISTANCE_LIMIT = 45 * u.deg and then compare to FOV_ANGULAR_DISTANCE_LIMIT.to_value(u.rad) instead of multiplying both sides with the unit (faster).
Maybe you can also put this part into a function so it looks like this:
if far_outside_fov(src_fov_lat, src_fov_lon):
return INVALID
maxnoe
requested changes
Feb 22, 2023
maxnoe
reviewed
Mar 8, 2023
ctapipe/reco/hillas_intersection.py
Outdated
| FOV_ANGULAR_DISTANCE_LIMIT = 45 * u.deg | ||
|
|
||
|
|
||
| def far_outside_fov(fov_lat, fov_lon): |
There was a problem hiding this comment.
I'd make this private (i.e. add an underscore in front)
maxnoe
reviewed
Mar 8, 2023
maxnoe
reviewed
Mar 8, 2023
|
Thanks! I will implement them and get back to you. |
kosack
requested changes
Mar 9, 2023
|
@gschwefer Could you add a change-log entry? Just create a file |
|
@gschwefer Can you merge or rebase with the current |
|
Yes I will |
gschwefer
force-pushed
the
hillasintersection_fix
branch
from
f751de2 to
2557709
Compare
kosack
approved these changes
Sep 6, 2023
maxnoe
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2264. Events with large reconstructed angular distances from the camera center now return the INVALID container.