-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or move examples to documentation #2266
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Note that this is only a first step to cleaning up the example and tutorial notebooks. The intention here is not to fix all of them, but just to remove the script example and make sure anything interesting in them was moved to the notebooks. There will have to be a more complete overhaul of the documentation notebooks at a future point, as they are missing a large amount of information and contain some outdated practices. |
Some errors in the docs build, seems like a spurious space?
|
Looks good, my only comment would be if we really need both the |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to pin nbsphinx to 0.8 as part of this PR to have the notebooks render correctly with our old sphinx version.
nbsphinx~=0.8.12
in setup.cfg and nbsphinx >=0.8.12,<0.9
in environment.yaml`
- removed many examples that are not redundant
also add ffmpeg-python to doc requirements also install ffmpeg binary
fix incorrect indentation remove link from changelog entry
I added the pin. @Tobychev Could you approve again? |
fixes #931
fixes #657