Fix neighbor matrix for no pixels, fixes #2316 #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosack
previously approved these changes
Apr 25, 2023
|
Does this really fix #2316? Is it understood what's going there? The example given doesn't seem to be a 1-pixel mask, but I also don't see how the given example could fail... |
|
Independent of if this is the whole fix for the issue reported in #2316 , I think it is the right fix to do for the sub issues of getting the neighbormatrix for 0 or 1 pixel camera geometry, which might happen with the masking. |
Tobychev
previously approved these changes
Apr 25, 2023
maxnoe
force-pushed
the
one_pixel_neighbor
branch
from
5275b65 to
1111bbb
Compare
kosack
previously approved these changes
Apr 25, 2023
|
After realizing in #2316 that the problem is passing a masked camera geometry to the number of islands function I now added a check for checking that the mask is as long as the geometry in |
kosack
approved these changes
Apr 26, 2023
Tobychev
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.