-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using toymodel in telescope frame #2349
Conversation
Just because I had the script already from #2347 hillas_overlay.mp4 |
c520c9a
to
d06cdf3
Compare
d06cdf3
to
c850540
Compare
Maybe we should just finish removing the CameraFrame versions of all of this... Then we only support TelescopeFrame, and you can transform into CameraFrame to see the result. |
Hi @maxnoe can you explain what bits are actually about the new functionality? Most of this seems to be more style refactoring so I'm not sure what bit is where it is important to look closely... |
Actually, none of this is style refactoring, it's all directly related to support the two frames we can have image parameters in. In the current main, we use The units checks prevented the toymodel to be used in the |
missing tests